Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external folder manipulation (fix #232) #2710

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

Enfyve
Copy link
Contributor

@Enfyve Enfyve commented Apr 25, 2021

Updates folder upon navigation (up, back, forward, in).

Also introduces a new button to refresh the current folder view when pressed or when hotkey pressed (F5 or Ctrl+R)

Scenarios tested:

  • navigate in
  • navigate up
  • navigate forward
  • navigate backward
  • click refresh button
  • press F5
  • press Ctrl+R
  • change file type
  • change view

Updates folder upon navigation (up, back, forward, in).

Also introduces a new button to refresh the current folder view when pressed or when hotkey pressed (F5 or ctrl+R)
@Enfyve Enfyve requested a review from dacap as a code owner April 25, 2021 23:09
@dacap dacap self-assigned this Apr 29, 2021
@dacap
Copy link
Member

dacap commented May 20, 2021

Hi @Enfyve, from what I can see from the PR it will invalidate cached items in all actions, does removing this condition achieve the same effect?

@Enfyve
Copy link
Contributor Author

Enfyve commented May 22, 2021

@dacap removing the condition alone does not, however further adjusting the condition does achieve the same effect in most scenarios except when adjusting views

+++  if (isFolder() ||
---  if (isFolder() &&
      // if the children list is empty, or the file-system version
      // change (it's like to say: the current m_children list
      // is outdated)...
+++      !m_children.empty()) {
---      (m_children.empty() ||
---       current_file_system_version > m_version)) {

@dacap
Copy link
Member

dacap commented May 3, 2022

Finally merged with several changes/fixes:

Mainly the list of files is not refreshed each time we change between folders (so the cache is not invalidated). Anyway a pending change to finally fix #232 would be something like #3275

@dacap
Copy link
Member

dacap commented May 3, 2022

And finally I almost forgot, thanks @Enfyve for this patch and the patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants