Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ash 3.0 Upgrade guide: make move to domain more prominent #970

Closed
dmitriid opened this issue Apr 3, 2024 · 2 comments · Fixed by #971
Closed

Ash 3.0 Upgrade guide: make move to domain more prominent #970

dmitriid opened this issue Apr 3, 2024 · 2 comments · Fixed by #971
Labels
documentation Improvements or additions to documentation

Comments

@dmitriid
Copy link
Contributor

dmitriid commented Apr 3, 2024 •
edited
Loading

Describe the bug

The announcement says:

It is very important that you read and follow the upgrade guide

However, the instruction to remove Registry and move everything into domain comes much earlier than the description of the Api->Domain change.

People who might not have followed the development of 3.0 will probably be confused. I know I was, and I knew about this :)

Proposed solution

Move the section Ash.Api is now Ash.Domain, and just this section before DSL Changes
@dmitriid dmitriid added bug Something isn't working needs review labels Apr 3, 2024
@zachdaniel
Copy link
Contributor

Good call. Would you want to PR this change?

@zachdaniel zachdaniel added documentation Improvements or additions to documentation and removed bug Something isn't working needs review labels Apr 3, 2024
@dmitriid dmitriid mentioned this issue Apr 3, 2024
Merged
1 task
@dmitriid
Copy link
Contributor Author

dmitriid commented Apr 3, 2024

@zachdaniel I forgot I could do that :) Opened #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move API -> Domain change to the top of upgrade doc dmitriid/ash
2 participants
@dmitriid @zachdaniel