Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integer_primary_key migration issue #34

Closed
totaltrash opened this issue Jan 7, 2021 · 1 comment
Closed

integer_primary_key migration issue #34

totaltrash opened this issue Jan 7, 2021 · 1 comment
Labels
bug Something isn't working needs review

Comments

@totaltrash
Copy link
Contributor

Describe the bug

The migrator generates a non-incrementing, nullable field for integer_primary_key.

To Reproduce

An attribute defined as:

integer_primary_key :id

generates:

add(:id, :integer, null: true, default: nil, primary_key: true)

Expected behavior

add(:id, :serial, null: false, primary_key: true)
@totaltrash totaltrash added bug Something isn't working needs review labels Jan 7, 2021
@zachdaniel
Copy link
Contributor

This is currently tracked in #32, thanks for reporting it in further detail!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs review
Projects
None yet
Development

No branches or pull requests

2 participants