Frameworks #15
Merged
Frameworks #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and I removed the |
| @@ -0,0 +1,15 @@ | |||
| @import UIKit; | |||
|
|
|||
| #define ExtendTraitEnvironment(specific_class) \ | |||
There was a problem hiding this comment.
Would've done this with Swift protocol extensions but couldn't get it figured out.
| PODFILE CHECKSUM: 2c0c73dfeef5174af308d83c7d6c5ec25554150d | ||
|
|
||
| COCOAPODS: 1.0.0.beta.2 | ||
| COCOAPODS: 0.39.0 |
There was a problem hiding this comment.
Send a PR with a Gemfile 😛
3 tasks
|
OK, updated to CocoaPods 1.0 beta thingy, also split out mock-specific stuff into the subspec. |
|
ace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK so this does a lot:
has_includeweirdness, so I took it out and moved mock-related stuff just to theMockssubspec. This makes it easier to maintain, but it's a breaking change, but we're pre-1.0 so following the CocoaPods philosophy: http://media3.giphy.com/media/DHgmBovno9Mli/giphy.gifUITraitEnvironment:UIViewandUIViewController.Note that I chose stubbing as an approach instead of something else. Why? The
UITraitEnvironmentprotocol contains the logic we're trying to stub, a readonly property. Subclassing was considered but every class-under-test would need to be subclassed, which is a pain. Stubbing works.Fixes #13.