Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Badge #3

Closed
fbiego opened this issue Feb 2, 2022 · 2 comments
Closed

New Badge #3

fbiego opened this issue Feb 2, 2022 · 2 comments

Comments

@fbiego
Copy link

fbiego commented Feb 2, 2022

Is it possible to integrate this badge from commits-top-badge to this project?

![commits.top ranking](https://iot.fbiego.com/api/v1/commits?user=fbiego&country=kenya&bg_color=333333&text_color=77fe89&border_color=89452e)

committers.top ranking

@ashkulz
Copy link
Owner

ashkulz commented Feb 3, 2022

@fbiego I'm not sure which of the options below you meant:

  1. mention the above markdown as an alternative in the generated site
  2. actually generate the badge itself via the CF Worker

If it's option 1, I'm not averse to linking to a landing page on your site which allows a user to build the badge.

If it's option 2, I think I like the current badge a bit more, yours feels too big. I'm not averse to loading it if given a variant=XXX query string and from the above URL, but I'm not sure about the uptime of your site (btw, why isn't the URL HTTPS?) as compared to shields.io. I'd have preferred to generate the SVG directly from the worker, but I wasn't sure about the widths etc and just pushed the problem elsewhere 🙂

@ashkulz
Copy link
Owner

ashkulz commented Jun 27, 2022

Please re-open if you can respond to the above comment, as I'm not sure what needs to happen here

@ashkulz ashkulz closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants