Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gander and Android 12 (SDK 31) Compatibility #40

Open
Skato58 opened this issue Jan 5, 2022 · 3 comments
Open

Gander and Android 12 (SDK 31) Compatibility #40

Skato58 opened this issue Jan 5, 2022 · 3 comments

Comments

@Skato58
Copy link

Skato58 commented Jan 5, 2022

Greetings,
We have been using Gander very happily for the passed few months, but have come across a problem.

When updating our App to target sdk 31 (Android 12), we get the following error message:

Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent. Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.

Which appears to be occurring inside the Gander library, specifically:

at com.ashokvarma.gander.internal.support.NotificationHelper.show(NotificationHelper.java:81)

.setContentIntent(PendingIntent.getActivity(mContext, 0, Gander.getLaunchIntent(mContext), 0)) <-

We are currently using com.ashokvarma.android:gander-imdb:3.1.0 for our project.

Is there an update to allow gander to work for android 12/SDK31 targeting projects? Or something that can be enabled which would do so?

Thanking you in advance.

@tianshaokai
Copy link

When will the new version of Android 12 be released

@tulang3587
Copy link

It appears we need to either wait for gander to be updated, or make another fork to fix the PendingIntent issue for API31 and above.

@Ashok-Varma
Copy link
Owner

Hi folks,

I'm planning to rewrite gander, with support to multiple platforms. Given no expected timelines for it.

  1. Feel free to raise PR for this
  2. You can use chucker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants