Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supersedence for out-of-order releases #88

Closed
theaquamarine opened this issue Feb 18, 2021 · 1 comment · Fixed by #91
Closed

Supersedence for out-of-order releases #88

theaquamarine opened this issue Feb 18, 2021 · 1 comment · Fixed by #91

Comments

@theaquamarine
Copy link
Contributor

Software that makes releases that aren't always in normal numerical order can currently end up with a higher release number superseded by a lower release number since supersedence always picks the most recently created application as the "old version", for example, PowerShell releasing 7.0.4 after 7.1.1 so 7.0.4 ends up superseding 7.1.1.

$Latest2Apps = Get-CMApplication -Name "$ApplicationName*" -Fast | Where-Object { ($_.Manufacturer -eq $ApplicationPublisher) -and ($_.IsExpired -eq $false) -and ($_.IsSuperseded -eq $false) } | Sort-Object DateCreated -Descending | Select-Object -first 2

The current system works fine in most situations and is great for software that doesn't have comparable version numbers for releases, but can't handle this at all - any thoughts? I can see two options

  • an option (or changing the default) to only accept higher versions in Invoke-VersionCheck, possibly per-application
  • and/or changing the sorting in Invoke-ApplicationSupersedence to use version number then date created and only superseding a lower version, also possibly per-application and possibly by default
@asjimene
Copy link
Owner

This is a very interesting annoying issue, checking version numbers would be a task, there are so many different ways app versions are represented, it becomes tough to generalize a version check function. This is why the current version check only determines if the downloaded version is different from the existing versions in ConfigMgr.

I think this might be better tackled on a per-app basis. I'm not sure of the PowerShell versioning, but it seems like they are working on 2 "branches", 7.0.x and 7.1.x, perhaps updating the recipe to only grab the 7.1.x releases would fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants