This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
Add support for Tulip Indicators #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code is very clean nice work. |
Because not all combinations of NPM version on windows have prebuilt packages, and python is needed to be able to install tulind properly.
|
Awesome stuff! Thanks a lot for your hard work :) I am not super happy with how sloppy I did the TAlib integration, but we can't wait forever before I have time to clean it up. So when I do I'll clean TAlib as well as tulip up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new feature by providing support for Tulip Indicators (via the tulind npm package), which provides a large library of efficient TA indicators that works on all operating systems.
It also provides a new simple strategy (tulip-macd) used to test the integration.
The indicator library is enabled by default, unlike TA-Lib since the library is available on all major OS's including windows.
Should resolve enhancement request #708