Updated binance market data using script provided in PR #1550 by @cmroche #1700
Conversation
|
👍 thanks :) |
|
Can binance market data using the script be done automatically when using import option form the Gekko UI? I think that would be great. If it hasn't been done, l'd love to do it myself. |
|
No, you have to manually run the update file. The reason we do it like this is so that we can make sure Gekko only works with markets that we have tested and seen. We could also dynamically look up markets whenever you start Gekko, but that defeats the purpose. |
|
What do you mean by tested and seen? Binance keeps adding new coins to the exchange, Gekko should support those trading pairs isn't it? I thought that was the purpose of the script. It's not a ideal to run it every time we use the importer but perhaps, a "sync currency pairs" button in the import page definitely helps. |
|
The problem is that there are differences in how they report their markets
and how they actually are. We are not handling it yet but we will, see
#1805
…On 7 Feb 2018 18:03, "nissimpradhan" ***@***.***> wrote:
What do you mean by tested and seen? Binance keeps adding new coins to the
exchange, Gekko should support those trading pairs isn't it? I thought that
was the purpose of the script.
It's not a ideal to run it every time we use the importer but perhaps, a
"sync currency pairs" button in the import page definitely helps.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1700 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA7MDzlELbsktCe1oJCRuRlWAtC0c95Tks5tSXUEgaJpZM4Rfs7K>
.
|
|
And honestly using gekko on brand new coins does not make sense. Gekko is
for trendwatching and momentum reversal. You can't do that on brand new
markets imo.
…On 7 Feb 2018 18:28, "Mike van Rossum" ***@***.***> wrote:
The problem is that there are differences in how they report their markets
and how they actually are. We are not handling it yet but we will, see
#1805
On 7 Feb 2018 18:03, "nissimpradhan" ***@***.***> wrote:
> What do you mean by tested and seen? Binance keeps adding new coins to
> the exchange, Gekko should support those trading pairs isn't it? I thought
> that was the purpose of the script.
>
> It's not a ideal to run it every time we use the importer but perhaps, a
> "sync currency pairs" button in the import page definitely helps.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#1700 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AA7MDzlELbsktCe1oJCRuRlWAtC0c95Tks5tSXUEgaJpZM4Rfs7K>
> .
>
|
|
I am new to Gekko. This discussion is very confusing. I would like to see more coins available in Gekko for trading listed by Bianance. If an update has been prepared that will accomplish this I would like to know how to install the update. Thanks |
|
jbghub, here's a way to update for more coins without having to use any other tools: -Make a backup copy of gekko/exchanges/binance.js |
|
Thank you so much. I will implement later this evening.
…Sent from my iPhone
On Feb 27, 2018, at 7:31 PM, stereohelix ***@***.***> wrote:
jbghub, here's a way to update for more coins without having to use any other tools:
-Make a backup copy of gekko/exchanges/binance.js
-Then open your current file, copy the contents of this into it, and save:
https://github.com/askmike/gekko/blob/c3de6f653930b1a8a58ef5071cfd0537664dc7d3/exchanges/binance.js
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I updated the binance.js file as stated. However, I am still only seeing the same 5 coins in the Gekko app. Any suggestions? |
|
Stop and restart gekko? |
|
Yes, Stopped, Restarted Gekko; also rebooted PC. Any other ideas? |
|
I am using the Admin Command window to start Gekko: |
|
Hi jbghub, Good luck, hope that helps. |
|
I found this code in the package-lock file: Could this have anything to do with the binance file not working for me? |
|
I'm not sure. But that is a little out-of-date. You could try But I should really add a disclaimor that I'm in over my head here -- if this causes some other conflict, you might end up having to reinstall gekko. Which might be fine, and might actually solve whatever issue is happening. |
|
I believe I found my problem. I was only looking at the USDT pairs. Their are many more coins for other currencies (coins) instead of USDT. |
|
Thanks for all your help. |
|
Great! |
|
Quesion: How did you determine the Precision of each coin? |
|
The easiest way is to look on the Binance website. The precision is the least significance digit of the price. |
|
@stereohelix @jbghub Right now it happens to be the least significant digit of each coin, but Binance does publish somewhere in their documents and official list, and it is queryable through their API for official values as there is no guarantee of this relationship in the future. |
|
Here's the official document (it's actually pretty up-to-date, not 8 months old) |
Fix for #1678
Updated binance market data using the script provided in PR #1550 by @cmroche