Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-check for xinput #48

Closed
kitingChris opened this issue Mar 19, 2020 · 3 comments
Closed

Pre-check for xinput #48

kitingChris opened this issue Mar 19, 2020 · 3 comments
Assignees

Comments

@kitingChris
Copy link

kitingChris commented Mar 19, 2020

On Debian Testing with GNOME Shell 3.34.4

TypeError: comp[1] is undefined
Stack trace:
  _listPointingDevices@/home/chris/.local/share/gnome-shell/extensions/touchpad-indicator@orangeshirt/xinput.js:60:13
  _init@/home/chris/.local/share/gnome-shell/extensions/touchpad-indicator@orangeshirt/xinput.js:42:32
  XInput@/home/chris/.local/share/gnome-shell/extensions/touchpad-indicator@orangeshirt/xinput.js:37:9
  TouchpadIndicatorSettings@/home/chris/.local/share/gnome-shell/extensions/touchpad-indicator@orangeshirt/prefs.js:44:22
  buildPrefsWidget@/home/chris/.local/share/gnome-shell/extensions/touchpad-indicator@orangeshirt/prefs.js:239:20
  _showPrefs@resource:///org/gnome/shell/extensionPrefs/main.js:57:22
  _extensionsLoaded@resource:///org/gnome/shell/extensionPrefs/main.js:320:13
  _scanExtensions/<@resource:///org/gnome/shell/extensionPrefs/main.js:298:13
  asyncCallback@resource:///org/gnome/gjs/modules/overrides/Gio.js:132:13
  main@resource:///org/gnome/shell/extensionPrefs/main.js:707:5
  @<main>:1:43
@kitingChris
Copy link
Author

I had a look into xinput.js:60:13

        let comp = Lib.executeCmdSync('xinput --list');
        let allDeviceLines = comp[1].split('\n');

Found out xinput was missing on my new system....

But perhaps checking if xinput is available and throwing an error with a more helpful message might be an idea ;)

@askmrsinh
Copy link
Owner

Yup, checking beforehand would be better.

@askmrsinh askmrsinh changed the title TypeError: comp[1] is undefined Pre-check for xinput Mar 28, 2020
@askmrsinh askmrsinh self-assigned this Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants