-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements enum[] #482
Implements enum[] #482
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me. I just left a couple of small comments. Since we're operating on arrays, I would use a unique keyword contains
, where the value is either polymorphic (string or array of strings), or monomorphic (contains
must include an array of 1 element).
1f8db4d
to
8d19681
Compare
Implement just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In the future we might want to add another PR to implement a function for intersection
With this PR, I want to introduce the
enum[]
as the follower of #458So,
This PR introduces
contains
, andintersects
operators because they are more appropriate for arrays.enum
andenum[]