fix double pagination issue in hybrid search with where clause, fixes #730 #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@micheleriva , up for review. |
abhishek818
force-pushed
the
hybrid_search_where_clause_fix
branch
from
5df918b
to
4c99ed9
Compare
|
This doesn't fix the upperbounding of the count |
|
Totally forgot that part, have fixed it now @nicolastoulemont |
|
@micheleriva, just bumping this. |
abhishek818
force-pushed
the
hybrid_search_where_clause_fix
branch
from
ef0e08f
to
ffdf888
Compare
|
@micheleriva @nicolastoulemont pls review this. |
|
Superseded by #731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #730
Closes #730