Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SQLite #5

Closed
aslotte opened this issue May 19, 2020 · 14 comments
Closed

Add support for SQLite #5

aslotte opened this issue May 19, 2020 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@aslotte
Copy link
Owner

aslotte commented May 19, 2020

Registering models and metadata in the cloud is not always feasible.
To that effect we want to be able to add a provider to store these things on-premise

@aslotte aslotte added the enhancement New feature or request label May 19, 2020
@aslotte
Copy link
Owner Author

aslotte commented May 24, 2020

We probably want to start off with supporting SQL Server and a local file share. It would make sense that this was added to a separate package MLOps.NET.Local.SqlServer

@dcostea
Copy link
Collaborator

dcostea commented Jun 2, 2020

@aslotte , do you mind if I'm considering adding SQLite? I think it will do just fine here, instead of SqlServer. But we can think of doing both, SqlServer and SQLite.

@aslotte
Copy link
Owner Author

aslotte commented Jun 2, 2020

@dcostea we can certainly look at SQLite if you like. My thinking is that most organizations that want to start of locally will have some kind of SQL server set up, but that may be a misconception :)
Would love to discuss it tomorrow if you're joining the stream. I'm thinking we may want to spend a bit more time finding a general API we're happy with in Azure before working on the local solution.

@dcostea
Copy link
Collaborator

dcostea commented Jun 2, 2020

@aslotte , sure, let's talk tomorrow.

@sammysemantics
Copy link

I agree with @dcostea. For development purposes, using SQLite is easier to use instead of a full server setup. I completely agree that enterprises will want to use connect with SQL server, but that can be implemented later.

Also, I'm unsure of the naming convention of MLOps.NET.Local._______. I am unsure of the 'Local' addition. Because if we used that, shouldn't we change the name up for MLOps.NET.Azure to MLOps.NET.RemoteStorage/Cloud.Azure. If we drop the '.Local", it will be more consistence with the current naming schema because the extension's name should be self-evident enough.

@aslotte
Copy link
Owner Author

aslotte commented Jun 2, 2020

Great input @sammysemantics. To address some of your points:

  • I'm all good trying SQLite to start with
  • Maybe the name of the package should be MLOps.NET.SQLite?

Like that we can have additional packages for e.g. MLOps.NET.AWS if we open up for AWS as a storage provider.

@aslotte
Copy link
Owner Author

aslotte commented Jun 2, 2020

It could also be called MLOps.NET.LocalStorage.SQLite and we could have MLOps.NET.LocalStorage.SqlServer etc.

@sammysemantics
Copy link

If we rename it MLOps.NET.LocalStorage.*, should we rename the Azure extension to MLOps.NET.RemoteStorage (or CloudStorage).Azure? Because I do see more extensions to this library that fits outside of storage and focuses on other operations in the MLOps lifecycle.

@aslotte
Copy link
Owner Author

aslotte commented Jun 2, 2020

@sammysemantics - what do you think about re-naming it to MLOps.NET.Storage.Azure and MLOps.NET.Storage.SQLite etc.?

@dcostea
Copy link
Collaborator

dcostea commented Jun 2, 2020

@sammysemantics - what do you think about re-naming it to MLOps.NET.Storage.Azure and MLOps.NET.Storage.SQLite etc.?

For me, it's better this way. Azure and SQLite are intrinsic local or remote, so there is no need to encode this in the namespace.

@aslotte aslotte changed the title Add support for local file provider Add support for SQLite local provider Jun 2, 2020
@aslotte
Copy link
Owner Author

aslotte commented Jun 3, 2020

@dcostea just so I understand your last comment, do you think they should be called MLOps.NET.Storage.Azure or MLOps.NET.Azure for example?

I personally prefer MLOps.NET.Azure but I'm good with either and want to make sure it makes sense to you, @sammysemantics and others.

@dcostea
Copy link
Collaborator

dcostea commented Jun 3, 2020

If we don't plan to have more modules related to Azure, then I prefer the shorter one, MLOps.NET.Azure. Similarly MLOps.NET.SQLite.

@aslotte aslotte changed the title Add support for SQLite local provider Add support for SQLite Jun 3, 2020
@sammysemantics
Copy link

Agreed.

@aslotte
Copy link
Owner Author

aslotte commented Jun 3, 2020

Perfect, that sounds great.

@aslotte aslotte closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants