Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag new release #24

Closed
barryvdh opened this issue Jan 11, 2016 · 8 comments
Closed

Tag new release #24

barryvdh opened this issue Jan 11, 2016 · 8 comments

Comments

@barryvdh
Copy link
Collaborator

Could you tag a new release with the Symfony 3 support please?

@GrahamCampbell
Copy link
Contributor

Ping @asm89.

@barryvdh
Copy link
Collaborator Author

barryvdh commented Feb 2, 2016

Sorry to be a bit pushy, but this is blocking the installation for a lot of users (on Laravel 5.2+). So I either need a stable tag, or I need to create/maintain a fork, which isn't really ideal.

@Sopamo
Copy link

Sopamo commented Feb 4, 2016

Yeah, we would really like to use the laravel-cors package from barryvdh, but can't due to this issue.

@GrahamCampbell
Copy link
Contributor

Yeah, we would really like to use the laravel-cors package from barryvdh, but can't due to this issue.

Not quite true, but yeh.

@GrahamCampbell
Copy link
Contributor

For example, Cachet uses this and laravel 5.2: https://github.com/CachetHQ/Cachet/blob/master/composer.json.

@Sopamo
Copy link

Sopamo commented Feb 4, 2016

Oh, wow, I wasn't aware that you could override a package like that with composer. Thanks!

@GrahamCampbell
Copy link
Contributor

Yeh, it's not pretty, but it works for now. :)

@barryvdh
Copy link
Collaborator Author

I've just forked the classes in my own project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants