New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack middleware causes loss of existing Vary headers #60

Closed

mglaman opened this issue Jan 9, 2020 · 1 comment

mglaman commented Jan 9, 2020

If you have already set the Vary headers, it may be an array.

        if (!$response->headers->has('Vary')) {
            $response->headers->set('Vary', 'Origin');
        } else {
            $response->headers->set('Vary', $response->headers->get('Vary') . ', Origin');
        }

This tries to perform string concatenation on an array, resulting in the Vary header always be , Vary.

The text was updated successfully, but these errors were encountered:

Author

mglaman commented Jan 9, 2020

Nevermind, apologies. Something is causing the first value in the parameter bag to be null,

mglaman closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment