This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Heap & asm instance pooling #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, I'll do my best to get this merged this week! |
|
Will this get merged? |
|
ping @alippai |
|
@alippai Will this get merged? |
TheUltDev
suggested changes
Feb 4, 2021
| @@ -13,7 +13,32 @@ export abstract class Hash<T extends sha1result | sha256result | sha512result> { | |||
| public BLOCK_SIZE!: number; | |||
| public HASH_SIZE!: number; | |||
|
|
|||
| protected static heap_pool !: Array; | |||
| protected static asm_pool !: Array; | |||
| protected static asm_function!: Function; | |||
There was a problem hiding this comment.
A definite assignment assertion '!' is not permitted in this context.
Generic type 'Array<T>' requires 1 type argument(s).
| protected acquire_asm() { | ||
| if (this.heap === undefined && this.asm === undefined) { | ||
| this.heap = this.constructor.heap_pool.pop() || _heap_init(); | ||
| this.asm = this.constructor.asm_pool.pop() || this.constructor.asm_function({ Uint8Array: Uint8Array }, null, this.heap.buffer); |
There was a problem hiding this comment.
Property 'heap_pool' does not exist on type 'Function'
Property 'asm_pool' does not exist on type
Property 'asm_function' does not exist on type 'Function'
|
|
||
| protected release_asm() { | ||
| this.constructor.heap_pool.push(this.heap)); | ||
| this.constructor.asm_pool.push(this.asm); |
There was a problem hiding this comment.
Property 'heap_pool' does not exist on type 'Function'
';' expected (extra parenthesis)
Property 'asm_pool' does not exist on type 'Function'
|
Hey 👋 There is an updated implementation of this, here: openpgpjs@6e5fe3f. If there's interest from the maintainers I'd be happy to update this PR to that; alternatively you can also use that fork in the meantime. |
|
@alippai any chances that this can get picked back up? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #154 (Improving Firefox performance). Also, bring back
sha*.bytes()convenience functions.