Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify TC when handling TC #77

Closed
AlianBenabdallah opened this issue Jan 20, 2023 · 0 comments · Fixed by #78
Closed

Verify TC when handling TC #77

AlianBenabdallah opened this issue Jan 20, 2023 · 0 comments · Fixed by #78

Comments

@AlianBenabdallah
Copy link

In handle_tc, the validity of the TC is not checked:

async fn handle_tc(&mut self, tc: TC) -> ConsensusResult<()> {
if tc.round < self.round {
return Ok(());
}
self.advance_round(tc.round).await;
if self.name == self.leader_elector.get_leader(self.round) {
self.generate_proposal(Some(tc)).await;
}
Ok(())

If I am not wrong, any malicious node could send a TC, making correct nodes moving to the next round.

@asonnino asonnino mentioned this issue Jan 23, 2023
@asonnino asonnino linked a pull request Jan 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant