Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt-UP crashes if the first line in the buffer is empty #218

Closed
gryzus24 opened this issue Mar 21, 2022 · 2 comments · Fixed by #220
Closed

Alt-UP crashes if the first line in the buffer is empty #218

gryzus24 opened this issue Mar 21, 2022 · 2 comments · Fixed by #220

Comments

@gryzus24
Copy link
Contributor

To reproduce:

  • open babi
  • press enter
  • press Alt-UP

This happens because there is no bound check in Alt-UP action implementation when counting the offset.

I can issue a pull request with slightly different implementation where the bound check is obvious. If you would like to keep the current code it suffices to add two more if statements.
@asottile
Copy link
Owner

huh, I didn't even know there was an alt+up keyboard shortcut

@gryzus24 gryzus24 mentioned this issue Mar 21, 2022
Closed
@asottile
Copy link
Owner

ah it was added in #179 by @ClasherKasten

@ClasherKasten ClasherKasten mentioned this issue Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@asottile @gryzus24