-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to disable specific upgrades #63
Comments
I'd suggest letting go of the past. printf-style formatting has been replaced (twice now! first with pyupgrade is an opinionated tool and will not be enabling opt-out of features except by language version. |
If you're not convinced, I'd suggest reading through https://pyformat.info -- and perhaps this list of oddities |
@asottile No need to convince me since I mentioned the reason which has nothing to do with Python at all. Let me troll you some more: we also use double quotes hehe. No worries. I will fork the project for our org and will maintain it under a different package name. |
That was my PR, and the One is that Another is that Some just prefer the old style, especially for those switching between languages (like @vmarkovtsev). @vmarkovtsev Please let me know when the fork is ready, it'd be useful for those cases when needing to revert and redo. Thanks! |
Without conversion there's no direct conversion to f-strings which are faster. If you're worried about performance differences between % formatting and .format() you're using the wrong language, python is slow. |
you know, now that I see how simple the change would be to opt out of percent formatting, make a PR -- I'll accept it 😭 sorry about the runaround |
This is available in 1.8.0. |
LOL I knew your nerves would not bare this 😆 That's a pity - I have just passed through the CI checks and prepared the fork for pypi. |
Hi. It's been some time.
Thanks for considering my request! |
no means no |
E.g. our style guide forces printf-like syntax (we switch to C-like languages often and cut the corners) and we have to revert the corresponding upgrades as in src-d/ml#322 (review)
So would be nice to enable/disable features besides the master switch by Python version.
The text was updated successfully, but these errors were encountered: