Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements you may want to backport #9

Closed
GoogleCodeExporter opened this issue Mar 3, 2016 · 1 comment
Closed

Some improvements you may want to backport #9

GoogleCodeExporter opened this issue Mar 3, 2016 · 1 comment

Comments

@GoogleCodeExporter
Copy link

The mimeparse module had been included in Python Paste a long time ago.

Not being aware that it was taken from here, I made some improvements to the 
module and added unit tests in the Python code base:

http://bitbucket.org/ianb/paste/src/tip/paste/util/mimeparse.py
http://bitbucket.org/ianb/paste/src/tip/tests/test_util/test_mimeparse.py

I have now added a link to the mimeparse project page to the source to make 
this clearer, and made my test module also include the test cases provided here.

Maybe you want to backport my version.

Note that I made a small incompatible change to best_match: In case of 
ambiguity, my method returns the *first* of the best mime types from the list, 
not the *last* one. I think this makes more sense. I have also mentioned this 
in the docstring.

Original issue reported on code.google.com by ch.zwerschke@gmail.com on 19 Aug 2010 at 4:32

@GoogleCodeExporter
Copy link
Author

The fix you mention is now in 0.1.3 of the Python version of the library. 
Thanks!

Original comment by joe.gregorio@gmail.com on 15 Sep 2010 at 8:40

  • Changed state: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant