-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose a config_setting for copy execution_requirements #606
Conversation
lib/copy_directory.bzl
Outdated
NB: if you use Remote Execution and Build-without-the-bytes, then you'll want the copy action to | ||
occur on the remote machine. You should therefore disable our `copy_use_local_execution` flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could you give one more tidbit about why they want the copy action to occur on the remote machine? Is it just to avoid some warnings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/copy_directory.bzl
Outdated
NB: if you use Remote Execution and Build-without-the-bytes, then you'll want the copy action to | ||
occur on the remote machine. You should therefore disable our `copy_use_local_execution` flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* feat: expose a config_setting for copy execution_requirements Fixes #604 * chore: add user docs * chore: improve docs * chore: better link to copy_file
* feat: expose a config_setting for copy execution_requirements Fixes #604 * chore: add user docs * chore: improve docs * chore: better link to copy_file
* feat: expose a config_setting for copy execution_requirements Fixes #604 * chore: add user docs * chore: improve docs * chore: better link to copy_file
* feat: expose a config_setting for copy execution_requirements Fixes #604 * chore: add user docs * chore: improve docs * chore: better link to copy_file
Alternative to #605
Fixes #604
Fixes #466
Type of change
For changes visible to end-users
If you rely on Remote Execution and Build-without-the-bytes, you should add to your
.bazelrc
:(with Bazel 6.4 or greater)
common --@aspect_bazel_lib//lib:copy_use_local_execution=false
or with Bazel 6.3 or earlier:
Test plan
Run aquery locally: