Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announcement] : Removed DefaultHttpContext extensibility #6534

Closed
davidfowl opened this issue Jan 9, 2019 · 1 comment
Closed

[Announcement] : Removed DefaultHttpContext extensibility #6534

davidfowl opened this issue Jan 9, 2019 · 1 comment
Labels
breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Milestone

Comments

@davidfowl
Copy link
Member

davidfowl commented Jan 9, 2019

Discussion for aspnet/Announcements#338

As part of performance improvements made to ASP.NET Core 3.0 (#6504), we've removed the extensibility of DefaultHttpContext (it is now sealed). This extensibility was provided initially to allow pooling of the HttpContext but it introduced more complexity than necessary and precluded other optimizations. As a result, we decided to remove this extensibility.

If you're using Mock in your unit tests, we recommend using Mock instead.

@davidfowl davidfowl added the breaking-change This issue / pr will introduce a breaking change, when resolved / merged. label Jan 9, 2019
@davidfowl davidfowl added this to the Discussions milestone Jan 9, 2019
@aspnet-hello
Copy link

We periodically close 'discussion' issues that have not been updated in a long period of time.

We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.

@dotnet dotnet locked and limited conversation to collaborators Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Projects
None yet
Development

No branches or pull requests

3 participants