Merge Kestrel 2.2 #4031
Merged
Merge Kestrel 2.2 #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Making progress towards being able to use the connection objects on the client side.
[auto-updated: dependencies]
* Allow app to drain request buffer after FIN
[auto-updated: dependencies]
# Conflicts: # build/dependencies.props # korebuild-lock.txt # src/Kestrel.Transport.Libuv/Internal/LibuvConnectionContext.cs
This reverts commit 8e9f05b.
This reverts commit fe9da3c.
* Relieve response backpressure immediately when closing socket
[auto-updated: dependencies]
- Move ProcessRequest into ParseHttpRequest (out of state machine) - Use struct adapter for parsing - Non-virtual calls - RequestType to enum - Readonly statics and early init statics - Early init path statics - Faster Json fall through - CountingBufferWriter -> Smaller BufferWriter - Pre-init date static - Smaller WriteNumeric
- fix an issue with tests running as root on VSTS
Prior to this, only the response body counted toward the HTTP/2 response data rate. This PR aligns the HTTP/2 logic closer to the HTTP/1.x logic and measures the rate for all HTTP/2 response data. This PR also accounts for all response bytes written, not just those that immediately induced backpressure.
This might help address #3015 This only affects rate timeouts. Normal fixed timeouts might deserve the same treatment, but that would require some additional locking to ensure we don't modify the sentinel value.
The _streams dictionary may not contain the completing stream in OnStreamCompleted since the IsDraining flag is applied beforehand which allows it to be removed by the request processing thread.
Prior to this change, HTTP/2 read rate limit tests would fail when the stalled read started after the test started advancing the clock.
Prior to reorganization, this source code was found in https://github.com/aspnet/CodeGenerator/tree/15ba5065a9b220f545eb3118d9e552f0b7e824d0
…or Kestrel packages
…estrel test projects have the test logger installed
This reverts commit 0029b8f.
Prior to reorganization, this source code was found in https://github.com/aspnet/KestrelHttpServer/tree/4598850c20047554d59b08e3d1edab47c2d7fe69
natemcmaster
force-pushed
the
namc/merge-k-2.2
branch
2 times, most recently
from
554c436
to
9c48b1a
Compare
Tratcher
reviewed
Nov 15, 2018
| <Package Id="Microsoft.AspNetCore.DataProtection.Abstractions" Version="2.2.0" /> | ||
| <Package Id="Microsoft.AspNetCore.DataProtection.AzureKeyVault" Version="2.2.0" /> | ||
| <Package Id="Microsoft.AspNetCore.DataProtection.AzureStorage" Version="2.2.0" /> | ||
| <Package Id="Microsoft.AspNetCore.DataProtection.EntityFrameworkCore" Version="2.2.0" /> | ||
| <Package Id="Microsoft.AspNetCore.DataProtection.Extensions" Version="2.2.0" /> | ||
| <Package Id="Microsoft.AspNetCore.DataProtection.StackExchangeRedis" Version="2.2.0" /> | ||
| <Package Id="Microsoft.AspNetCore.DataProtection.SystemWeb" Version="2.2.0" /> | ||
| <Package Id="Microsoft.AspNetCore.DataProtection" Version="2.2.0" /> |
There was a problem hiding this comment.
What changed in the sorting rules such that the base package is now last?
There was a problem hiding this comment.
I was manually sorting before and ran the sort lines command in VS Code. As it gets longer, manually sorting will be a pain
Tratcher
approved these changes
Nov 15, 2018
natemcmaster
force-pushed
the
namc/merge-k-2.2
branch
from
e0095a1
to
0271428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges release/2.1 and aspnet/KestrelHttpServer release/2.2.