Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loc build #33

Closed
dougbu opened this issue Nov 15, 2016 · 5 comments
Closed

Fix loc build #33

dougbu opened this issue Nov 15, 2016 · 5 comments
Assignees

Comments

@dougbu
Copy link
Member

dougbu commented Nov 15, 2016

Not sure localized builds of the template projects are working on the CI. Certainly, Web Stack Runtime / Main.Signed.AllLanguages builds succeed only because lsbuild.exe errors like the following are ignored:

Task "Exec"
  SET RazorLocParserBuildDirectory=C:\WSR\Tooling\bin\Release\&C:\WSR\Tooling\tools\loc\lsbuild.exe response C:\WSR\Tooling\obj\Release\loc\xo3cgpzm.zdnBatch.response
  Microsoft Localization Studio Build Tools Version 6.11.2218.0 (6.0.0.0)
  LocStudio Build Tool
  Copyright (c) Microsoft Corporation. All rights reserved.

  LSBuild : > Starting 'parse /p 305 /l en-US  /s C:\WSR\Tooling\tools\loc\default.lss  /s C:\WSR\Tooling\tools\loc\CommentAndUI_SourceEncoding.lss /o C:\WSR\Tooling\bin\Release\FRA\src\Templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lcg /c C:\WSR\Tooling\localize\comments\templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lci C:\WSR\Tooling\obj\Release\OneMvcTemplates\TemplateSource\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml'
  LSBuild :   > Parsing File 'C:\WSR\Tooling\obj\Release\OneMvcTemplates\TemplateSource\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml'
  LSBuild :     Error BL1024 - RazorLocParser.dll - C:\WSR\Tooling\obj\Release\OneMvcTemplates\TemplateSource\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml(7:0,7): The 'model' keyword must be followed by a type name on the same line.
  LSBuild :     > LSBuild-Parse
  LSBuild :     < Done.
  LSBuild :     > Processing Comments
  LSBuild :       > Processing Commenting file 'C:\WSR\Tooling\localize\comments\templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lci'
  LSBuild :       < Done
  LSBuild :     < Done
  LSBuild :     > Validating Resources
  LSBuild :     < Done
  LSBuild :   < Done
  LSBuild : < The command completed successfully. Elapsed time 0.4843692 seconds
  LSBuild : > Starting 'generate /p 305 /d fr-FR /iu   /s C:\WSR\Tooling\tools\loc\default.lss  /s C:\WSR\Tooling\tools\loc\CommentAndUI_SourceEncoding.lss /c C:\WSR\Tooling\localize\comments\templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lci /ol C:\WSR\Tooling\bin\Release\FRA\src\Templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lcx /t C:\WSR\Tooling\localize\FRA\templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lcl /o C:\WSR\Tooling\bin\Release\FRA\src\Templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml C:\WSR\Tooling\obj\Release\OneMvcTemplates\TemplateSource\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml'
  LSBuild :   > Generating 'C:\WSR\Tooling\bin\Release\FRA\src\Templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml'
  LSBuild :     > Generating File 'C:\WSR\Tooling\bin\Release\FRA\src\Templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml'
  LSBuild :       > Parsing File 'C:\WSR\Tooling\obj\Release\OneMvcTemplates\TemplateSource\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml'
  LSBuild :         Error BL1024 - RazorLocParser.dll - C:\WSR\Tooling\obj\Release\OneMvcTemplates\TemplateSource\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml(7:0,7): The 'model' keyword must be followed by a type name on the same line.
  LSBuild :         > LSBuild-Parse
  LSBuild :         < Done.
  LSBuild :         > Processing Comments
  LSBuild :           > Processing Commenting file 'C:\WSR\Tooling\localize\comments\templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lci'
  LSBuild :           < Done
  LSBuild :         < Done
  LSBuild :       < Done
  LSBuild :       > Updating Translation File 'C:\WSR\Tooling\localize\FRA\templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lcl'
  LSBuild :       < Done
  LSBuild :       Error BL1024 - RazorLocParser.dll - C:\WSR\Tooling\obj\Release\OneMvcTemplates\TemplateSource\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml(7:0,7): The 'model' keyword must be followed by a type name on the same line.
  LSBuild :       > LSBuild-Generate
  LSBuild :       < Done.
  LSBuild :     < Done
  LSBuild :     > Saving translation file 'C:\WSR\Tooling\bin\Release\FRA\src\Templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml.lcx'
  LSBuild :     < Done
  LSBuild :   < Generate failed : 'C:\WSR\Tooling\bin\Release\FRA\src\Templates\OneMvc\Templates\MvcBasicApplication\_OrgAuth\_Read\Views\Home\UserProfile.cshtml'
  LSBuild : < The command completed successfully. Elapsed time 0.641679 seconds

C:\WSR\Tooling\Loc.proj(3130,9): warning MSB3073: The command "SET RazorLocParserBuildDirectory=C:\WSR\Tooling\bin\Release\&C:\WSR\Tooling\tools\loc\lsbuild.exe response C:\WSR\Tooling\obj\Release\loc\xo3cgpzm.zdnBatch.response" exited with code 1.
  The previous error was converted to a warning because the task was called with ContinueOnError=true.
  Build continuing because "ContinueOnError" on the task "Exec" is set to "true".
Done executing task "Exec" -- FAILED.

FYI the above errors occur because the @model directives contain $safeprojectname$ in the type names. Probably need to substitute another token before calling the Razor parser and restore $safeprojectname$ after.

And the response files aren't 💯% correct:

  LSBuild : > Starting 'parse /l en-US  /s C:\WSR\Tooling\tools\loc\default.lss  /s C:\WSR\Tooling\tools\loc\locxml_WPT_nuspec.lss /o C:\WSR\Tooling\bin\Release\FRA\src\packages\LocalizationPackages\Microsoft.AspNet.Facebook\Microsoft.AspNet.Facebook.nuspec.lcg /c C:\WSR\Tooling\localize\comments\packages\Microsoft.AspNet.Facebook.nuspec.lci C:\WSR\Tooling\src\packages\LocalizationPackages\Microsoft.AspNet.Cors\Microsoft.AspNet.Facebook.nuspec'
  LSBuild :   Error CD0002 - The command threw an exception - File 'C:\WSR\Tooling\src\packages\LocalizationPackages\Microsoft.AspNet.Cors\Microsoft.AspNet.Facebook.nuspec' not found
  LSBuild : < The command failed.  Elapsed time 0 seconds
  LSBuild : > Starting 'generate /d fr-FR /iu   /s C:\WSR\Tooling\tools\loc\default.lss  /s C:\WSR\Tooling\tools\loc\locxml_WPT_nuspec.lss /c C:\WSR\Tooling\localize\comments\packages\Microsoft.AspNet.Facebook.nuspec.lci /ol C:\WSR\Tooling\bin\Release\FRA\src\packages\LocalizationPackages\Microsoft.AspNet.Facebook\Microsoft.AspNet.Facebook.nuspec.lcx /t C:\WSR\Tooling\localize\FRA\packages\LocalizationPackages\Microsoft.AspNet.Facebook.nuspec.lcl /o C:\WSR\Tooling\bin\Release\FRA\src\packages\LocalizationPackages\Microsoft.AspNet.Facebook\Microsoft.AspNet.Facebook.nuspec C:\WSR\Tooling\src\packages\LocalizationPackages\Microsoft.AspNet.Cors\Microsoft.AspNet.Facebook.nuspec'
  LSBuild :   > Generating 'C:\WSR\Tooling\bin\Release\FRA\src\packages\LocalizationPackages\Microsoft.AspNet.Facebook\Microsoft.AspNet.Facebook.nuspec'
  LSBuild :   < Generate failed : 'C:\WSR\Tooling\bin\Release\FRA\src\packages\LocalizationPackages\Microsoft.AspNet.Facebook\Microsoft.AspNet.Facebook.nuspec'
  LSBuild :   Error CD0002 - The command threw an exception - File 'C:\WSR\Tooling\src\packages\LocalizationPackages\Microsoft.AspNet.Cors\Microsoft.AspNet.Facebook.nuspec' not found
  LSBuild : < The command failed.  Elapsed time 0 seconds

Separately, Microsoft.AspNet.WebApi.Client.fr packages are available on http://www.nuget.org but not in our nightly CI feed on http://www.myget.org. This is more likely about nightly build configuration than anything else because the packages are created and signed in the CI builds. But is that configuration correct?

@danroth27 danroth27 added the task label Mar 3, 2017
@danroth27
Copy link
Member

danroth27 commented Mar 3, 2017

We should make sure we are building the satellite resources (even if that means disabling localized template builds #47).

@danroth27 danroth27 modified the milestone: 5.2.4 Mar 3, 2017
@joeloff
Copy link

joeloff commented Apr 19, 2017

You don't need to build any tooling from this branch. VS tooling has been building in separate branches without the runtime for the last 4 years. No active localization work has been done in Main since probably 2013 when WSR2 Refresh shipped.

@dougbu
Copy link
Member Author

dougbu commented Nov 1, 2017

Plan revision: Don't worry about the lack of localized resources for the PCL and .NET Standard assemblies. Focus on getting a clean build.

@dougbu
Copy link
Member Author

dougbu commented Nov 2, 2017

@joeloff I'm working to address this and may have lost some of the context. When you said "You don't need to build any tooling from this branch." above, what did you mean by "tooling"? For example, are all the scaffolding and template projects in that category?

My apologies if this is a duplicate of what I asked in #31.

@dougbu
Copy link
Member Author

dougbu commented Nov 7, 2017

Completed with TFS check-ins and DI configuration changes.

@dougbu dougbu closed this as completed Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants