StackOverflowException with InversePropertyAttribute on 1.1.0

[rowanmiller]

Reported over email...

I build a taxi service app with backend on ASP.NET Core.
In order to use latest SignalR I switched all package references to 1.2.0-* as it is defined in a SignalR repository. But as I try to perform any request to a database I receive StackOverflowException

I have the repro project for this (it couldn't be shared publically), so I can give it to whoever investigates.

Attaching stack trace as it is too big to add inline StackTrace.txt

[xperiandri]

This issue only appeared in 1.2
In 1.0 it worked, 1.1 I did not check.
My guess is that because of inheritance and circular navigation dependencies

[divega]

@AndriySvyryd please check if this was regressed in 1.1.

[xperiandri]

So I commented out all the navigation attributes except in CarRequest

        [ForeignKey("AcceptedResponseId")]
        public CarResponse AcceptedCarResponse { get; set; }

        //[ForeignKey(nameof(PassengerId))]
        //[InverseProperty(nameof(HahaTaxi.Entities.Passenger.CarRequests))]
        public virtual Passenger Passenger { get; set; }

        [InverseProperty(nameof(CarResponse.Request))]
        public virtual ICollection<CarResponse> CarResponses { get; set; }

And it works now

[AndriySvyryd]

Verified that the regression was in 1.1.0

[AndriySvyryd]

Fixed in cb79bb8

[Eilon]

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.