Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshots can lose annotations on non-primary keys #8716

Closed
ajcvickers opened this issue Jun 3, 2017 · 0 comments
Closed

Snapshots can lose annotations on non-primary keys #8716

ajcvickers opened this issue Jun 3, 2017 · 0 comments
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.0.0

Comments

@ajcvickers
Copy link
Member

CSharpSnapshotGenerator.GenerateKey is always called for primary keys, but only called for alternate keys that are not at the principal end of a relationship. This is usually good. However, if the key has annotations (such as constraint name, clustered, etc.) then these will not be generated. So if the key has annotations, then HasAlternateKey should be generated even if it is at the principal end of a relationship.
@ajcvickers ajcvickers added this to the 2.0.0 milestone Jun 5, 2017
@bricelam bricelam assigned smitpatel and unassigned bricelam Jun 23, 2017
@smitpatel smitpatel mentioned this issue Jun 28, 2017
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@bricelam @ajcvickers @smitpatel