Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

DefaultControllerActivator.Activate needs to be virtual #1526

Closed
pranavkm opened this issue Nov 7, 2014 · 4 comments
Closed

DefaultControllerActivator.Activate needs to be virtual #1526

pranavkm opened this issue Nov 7, 2014 · 4 comments
Assignees
@ajaybhargavb
Labels
3 - Done enhancement
Milestone
1.0.0-beta3

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Nov 7, 2014

The type also needs some love. Right now the only virtual method it has returns a IReadOnlyDictionary. This makes it difficult to modify the behavior of activation
@pranavkm
Copy link
Contributor Author

pranavkm commented Nov 7, 2014

For instance if I need to change how ModelStateDictionary gets activated, I need to create a new dictionary, copy the base dictionary and then add an entry for typeof(ModelStateDictionary)

@danroth27 danroth27 added this to the 6.0.0-rc1 milestone Nov 12, 2014
@danroth27 danroth27 modified the milestones: 6.0.0-beta2, 6.0.0-rc1 Nov 12, 2014
@danroth27
Copy link
Member

We should change IReadOnlyDictionary to IDictionary and we should do this for all of the activators.

@danroth27
Copy link
Member

Needs to be done in conjunction with #1707.

@danroth27 danroth27 modified the milestones: 6.0.0-rc1, 6.0.0-beta2 Dec 11, 2014
@ajaybhargavb ajaybhargavb mentioned this issue Jan 13, 2015
Merged
@ajaybhargavb
Copy link
Contributor

a5a3eb4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta3
Development

No branches or pull requests
3 participants
@pranavkm @ajaybhargavb @danroth27