Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Adding AuthorizePage & AuthorizeFolder without requiring a policy #5936

Closed
Eilon opened this issue Mar 9, 2017 · 6 comments
Closed

Adding AuthorizePage & AuthorizeFolder without requiring a policy #5936

Eilon opened this issue Mar 9, 2017 · 6 comments

Comments

@Eilon
Copy link
Member

Eilon commented Mar 9, 2017

From @hishamco on September 16, 2016 0:17

@rynowak It will be nice if we have an overload to authorize a page or a folder without requiring a policy to be supplied, perhaps I wanna use a simple cookie authentication that will handle the authentication process.
This is an equivalent to using AuthorizeAttribute in MVC controller or an action

Copied from original issue: aspnet/RazorPages#45

@pranavkm
Copy link
Contributor

pranavkm commented Mar 9, 2017

Makes sense. The policy attribute allows null-or-empty, we just need an extra pair of overloads for this.

@hishamco
Copy link
Contributor

hishamco commented Mar 9, 2017

I think I should push my old PR https://github.com/aspnet/RazorPages/pull/48 to the MVC repo

@pranavkm
Copy link
Contributor

pranavkm commented Mar 9, 2017

@hishamco, sure that sounds like a good idea.

@hishamco
Copy link
Contributor

While the old code has been changed!! for example removing ConstructableAuthorizationFilter, so I updated the PR little bit base on latest update in this repo

@Eilon
Copy link
Member Author

Eilon commented Mar 13, 2017

@hishamco thanks for the PR!

@pranavkm please continue to work with @hishamco on #5942 and close this bug when done.

@pranavkm
Copy link
Contributor

Thanks for the PR. Fixed in e44d875

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants