This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Eilon let's discuss and decide if the expectations in the skipped tests match what we want. |
dougbu
force-pushed
the
dougbu/testing.1485.1487.2662.2664
branch
from
d7a68c8
to
430e12c
Compare
- test additional cases _close_ to these bugs as well for #1485 - show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests - show odd `@Html.TextBox()` behaviour in functional tests (templates) for #1487 - show odd `@Html.Value()` behaviour in unit tests - show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests - show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper for #2662 - show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests for #2664 - show failures with `@Html.ListBox()` in unit tests nits: - test `IHtmlHelper` methods, not extensions - use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController` - name test methods a bit more consistently - rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
dougbu
force-pushed
the
dougbu/testing.1485.1487.2662.2664
branch
from
430e12c
to
0c0067b
Compare
|
Rebased (after @rynowak's refactorization) and minorly updated |
|
Based on our discussion I took a look and as best as I can tell these look good 😄
|
|
@afd5b4f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1485
@Html.CheckBox(),@Html.Hidden()behaviour in unit tests@Html.TextBox()behaviour in functional tests (templates)for #1487
@Html.Value()behaviour in unit tests@Html.RadioButton(),@Html.TextArea()behaviour in functional tests@Html.RadioButton(),<select>tag helperfor #2662
@Html.RadioButton(string.Empty)behaviour in functional testsfor #2664
@Html.ListBox()in unit testsnits:
IHtmlHelpermethods, not extensionsViewData, notViewBaginHtmlGeneration_FormControllerHtmlHelperValueExtensionsTesttoHtmlHelperValueTest