Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Some string-based HTML helpers can't get Model values if called from templates #1485

Closed
dougbu opened this issue Oct 30, 2014 · 4 comments
Closed

Some string-based HTML helpers can't get Model values if called from templates #1485

dougbu opened this issue Oct 30, 2014 · 4 comments
Assignees
@dougbu
Labels
3 - Done bug
Milestone
1.0.0-beta6

Comments

@dougbu
Copy link
Member

dougbu commented Oct 30, 2014

@Html.Checkbox(), @Html.Hidden(), and @Html.TextBox() do not behave as expected in template views. They resolve values using the full expression names (which won't find properties of the inner model), unlike all other HTML helpers. This leads to unexpectedly empty values in the generated HTML.
@rynowak
Copy link
Member

rynowak commented Oct 30, 2014

Is this a change from MVC 5?

Can you include an example and what the expected behavior should be?

@dougbu
Copy link
Member Author

dougbu commented Oct 30, 2014

MVC 5.2 has the same issue. This likely indicates templates aren't often used with string-based helpers.

Ex. Index.cshtml contains:

@Html.DisplayFor(model => model.Dependent, templateName: "Dependent")

DisplayTemplates/Dependent.cshtml contains:

<td>
    @Html.Label(expression: "Name", labelText: null, htmlAttributes: new { @class = "control-label", })
</td>
<td>
    '@Html.Value(name: "Name")'
</td>
<td>
    @Html.TextBox(name: "Name", value: null, htmlAttributes: new { disabled = "disabled", @readonly = "readonly", })
</td>

Result is:
capture

More details:
Workaround is to use expression-based equivalents of these helpers (@Html.CheckBoxFor() etc.) or tag helpers.

Fix is to change lines 810 and 834 of DefaultHtmlGenerator to pass name and not fullName.

@dougbu
Copy link
Member Author

dougbu commented Oct 30, 2014

... and the textbox should also contain "Dependents name" in the generated page.

@dougbu dougbu mentioned this issue Oct 30, 2014
Closed
@danroth27 danroth27 added this to the 6.0.0-rc1 milestone Nov 18, 2014
@yishaigalatzer yishaigalatzer modified the milestones: 6.0.0-beta3, 6.0.0-rc1 Jan 11, 2015
@yishaigalatzer yishaigalatzer modified the milestones: 6.0.0, 6.0.0-rc1 Feb 2, 2015
@Eilon Eilon removed this from the 6.0.0-beta5 milestone Apr 24, 2015
@Eilon Eilon added this to the 6.0.0-beta6 milestone May 8, 2015
This was referenced Jun 7, 2015
Closed
Closed
dougbu added a commit that referenced this issue Jun 8, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
c787522 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
@dougbu dougbu mentioned this issue Jun 8, 2015
Closed
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
d7a68c8 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
@dougbu dougbu mentioned this issue Jun 9, 2015
Closed
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
430e12c 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
cd138a9 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
dougbu added a commit that referenced this issue Jun 10, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
afd5b4f 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
dougbu added a commit that referenced this issue Jun 10, 2015
@dougbu
Make string-based expression evaluations behave consistently
6ef1c24 
- #1485, #1487
 - handle `TemplateInfo.HtmlFieldPrefix` in `ViewDataEvaluator.Eval()`
  - attempt lookup in the `ViewDataDictionary` using full name then evaluate
    relative `expression` against `viewData.Model`
  - handle `null` or empty `expression` special case in this method (remove `throw`s)
 - always pass relative `expression` name into `Eval()`
  - remove `null` or empty `expression` handling from higher-level code
  - in a couple of cases, special-case returned `ViewDataInfo`
- #2662
 - remove incorrect guard from `DefaultHtmlGenerator.GenerateRadioButtion()`
- add doc comments for the core methods that have changed
- enable unit tests skipped due to one of above bugs
 - fix one (yeah, just one) other test with incorrect expectations
- remove functional test comments about the above bugs and update expectations

nits:
- move some comments describing `ViewDataEvaluator` methods above the methods
@dougbu dougbu mentioned this issue Jun 10, 2015
Closed
dougbu added a commit that referenced this issue Jun 17, 2015
@dougbu
Make string-based expression evaluations behave consistently
27283ec 
- #1485, #1487
 - handle `TemplateInfo.HtmlFieldPrefix` in `ViewDataEvaluator.Eval()`
  - attempt lookup in the `ViewDataDictionary` using full name then evaluate
    relative `expression` against `viewData.Model`
  - handle `null` or empty `expression` special case in this method (remove `throw`s)
 - always pass relative `expression` name into `Eval()`
  - remove `null` or empty `expression` handling from higher-level code
  - in a couple of cases, special-case returned `ViewDataInfo`
- #2662
 - remove incorrect guard from `DefaultHtmlGenerator.GenerateRadioButtion()`
- add doc comments for the core methods that have changed
- enable unit tests skipped due to one of above bugs
 - fix one (yeah, just one) other test with incorrect expectations
- remove functional test comments about the above bugs and update expectations

nits:
- move some comments describing `ViewDataEvaluator` methods above the methods
@dougbu
Copy link
Member Author

dougbu commented Jun 17, 2015

27283ec

@dougbu dougbu closed this as completed Jun 17, 2015
@dougbu dougbu mentioned this issue Nov 28, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta6
Development

No branches or pull requests
5 participants
@Eilon @yishaigalatzer @rynowak @danroth27 @dougbu