Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

ArgumentNullException thrown in DefaultHtmlGenerator.GetCurrentValues() #2664

Closed
dougbu opened this issue Jun 8, 2015 · 2 comments
Closed

ArgumentNullException thrown in DefaultHtmlGenerator.GetCurrentValues() #2664

dougbu opened this issue Jun 8, 2015 · 2 comments
Assignees
@dougbu
Labels
3 - Done bug

Comments

@dougbu
Copy link
Member

dougbu commented Jun 8, 2015

When the model contains a collection of enum values and the view uses @Html.ListBox() for the property, GetCurrentValues() will throw an ArgumentNullException. Collections of enum values may be unusual but should be correctly supported.

The root cause is twofold: GetCurrentValues() determines the ModelExplorer for the property but uses that directly rather than the ModelMetadata for the element type. And the method assumes enumNames (from that ModelMetadata / ModelExplorer) will be non-null when a raw value is an enum.

The problem is a bit more general because it's possible to place enum values in ViewDataDictionary though the model is (say) an int. But that's much less likely than the collection case.
@dougbu
Copy link
Member Author

dougbu commented Jun 8, 2015

Self-assigning because this is also mixed into the #1485 / #1487 / #2662 mess.

@dougbu dougbu self-assigned this Jun 8, 2015
dougbu added a commit that referenced this issue Jun 8, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
c787522 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
@dougbu dougbu mentioned this issue Jun 8, 2015
Closed
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
#2664: Add ModelMetadata.ElementMetadata
4076e4f 
- builds on dougbu/testing.1485.1487.2662.2664 branch, unblocking some #1487 tests
- use new property to correctly determine `isTargetEnum` in `GetCurrentValues()`
 - avoid `ArgumentNullException` in all cases where raw values are `enum` but target is not
- also use new property instead of private `GetElementType()` methods where possible

nits:
- move properties above methods in `ModelMetadata`
- avoid accidentally-incorrect "Remove Unnecessary Usings"
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
d7a68c8 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
@dougbu dougbu mentioned this issue Jun 9, 2015
Closed
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
430e12c 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
#2664: Add ModelMetadata.ElementMetadata
cdbd283 
- builds on dougbu/testing.1485.1487.2662.2664 branch, unblocking some #1487 tests
- use new property to correctly determine `isTargetEnum` in `GetCurrentValues()`
 - avoid `ArgumentNullException` in all cases where raw values are `enum` but target is not
- also use new property instead of private `GetElementType()` methods where possible

nits:
- move properties above methods in `ModelMetadata`
- avoid accidentally-incorrect "Remove Unnecessary Usings"
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
cd138a9 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
dougbu added a commit that referenced this issue Jun 9, 2015
@dougbu
#2664: Add ModelMetadata.ElementMetadata
f58d801 
- builds on dougbu/testing.1485.1487.2662.2664 branch, unblocking some #1487 tests
- use new property to correctly determine `isTargetEnum` in `GetCurrentValues()`
 - avoid `ArgumentNullException` in all cases where raw values are `enum` but target is not
- also use new property instead of private `GetElementType()` methods where possible

nits:
- move properties above methods in `ModelMetadata`
- avoid accidentally-incorrect "Remove Unnecessary Usings"
dougbu added a commit that referenced this issue Jun 10, 2015
@dougbu
Demonstrate #1485, #1487, #2662, #2664 in functional and unit tests
afd5b4f 
- test additional cases _close_ to these bugs as well

for #1485
- show odd `@Html.CheckBox()`, `@Html.Hidden()` behaviour in unit tests
- show odd `@Html.TextBox()` behaviour in functional tests (templates)

for #1487
- show odd `@Html.Value()` behaviour in unit tests
- show odd `@Html.RadioButton()`, `@Html.TextArea()` behaviour in functional tests
- show lack of validation attributes for `@Html.RadioButton()`, `<select>` tag helper

for #2662
- show odd `@Html.RadioButton(string.Empty)` behaviour in functional tests

for #2664
- show failures with `@Html.ListBox()` in unit tests

nits:
- test `IHtmlHelper` methods, not extensions
- use `ViewData`, not `ViewBag` in `HtmlGeneration_FormController`
- name test methods a bit more consistently
- rename `HtmlHelperValueExtensionsTest` to `HtmlHelperValueTest`
dougbu added a commit that referenced this issue Jun 10, 2015
@dougbu
Add ModelMetadata.ElementMetadata
3f6ab3b 
- #2664
- use new property to correctly determine `isTargetEnum` in `GetCurrentValues()`
 - avoid `ArgumentNullException` in all cases where raw values are `enum` but target is not
- stop skipping tests blocked by #2664, exposing a couple more #1487 issues
- use new property instead of private `GetElementType()` methods where possible
 - cleans up some duplicate code
 - also remove redundant use of `IsCollectionType` and `ElementMetadata`

nits:
- move properties above methods in `ModelMetadata`
- avoid accidentally-incorrect "Remove Unnecessary Usings"
@dougbu
Copy link
Member Author

dougbu commented Jun 10, 2015

3f6ab3b

@dougbu dougbu closed this as completed Jun 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dougbu