Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Remove RazorIRVisitor<TResult> #1021

Closed
rynowak opened this issue Feb 17, 2017 · 3 comments
Closed

Remove RazorIRVisitor<TResult> #1021

rynowak opened this issue Feb 17, 2017 · 3 comments
Assignees
@ajaybhargavb
Labels
3 - Done enhancement up-for-grabs
Milestone
2.0.0-preview1

Comments

@rynowak
Copy link
Member

rynowak commented Feb 17, 2017

We haven't found a use for this yet, and it's adding boilerplate to all of our node classes.

It's likely we'll never use this because we're doing immutable data structures in the IR.
@Eilon Eilon modified the milestone: 2.0.0 Feb 28, 2017
@stefannikolei
Copy link
Contributor

@rynowak Do you mean this class: RazorIRNodeVisitor?

@rynowak
Copy link
Member Author

rynowak commented Mar 13, 2017

No, I mean this class https://github.com/aspnet/Razor/blob/dev/src/Microsoft.AspNetCore.Razor.Evolution/Intermediate/RazorIRNodeVisitorOfT.cs#L6

@stefannikolei stefannikolei mentioned this issue Mar 19, 2017
Merged
@ajaybhargavb
Copy link
Contributor

319c535

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done enhancement up-for-grabs
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
4 participants
@Eilon @stefannikolei @rynowak @ajaybhargavb