Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Identical @using statements from imports or defaults override those from main document #1174

Closed
NTaylorMullen opened this issue Apr 4, 2017 · 1 comment
Assignees

Comments

@NTaylorMullen
Copy link
Member

This results in 0 IntelliSense or coloring for using statements that match ones that exist on the main document.

The reason this occurs is we add using statement IR nodes as we encounter them and then make sure not to duplicate any. Problem is, we add ViewImports/default usings first which don't get source locations; when we encounter a using statement on the main document the using has already been added so we no-op in an effort to not duplicate an already added using.

@NTaylorMullen NTaylorMullen added this to the 2.0.0-preview1 milestone Apr 4, 2017
@NTaylorMullen NTaylorMullen self-assigned this Apr 4, 2017
NTaylorMullen added a commit that referenced this issue Apr 4, 2017
- The lazy addition of namespaces gives the main document lowering phase an opportunity to add source location information which we then add after the main lowering.
- Re-generated csharp to capture addition of using statements that were previously overridden by defaults/imports.

#1174
NTaylorMullen added a commit that referenced this issue Apr 4, 2017
- The lazy addition of namespaces gives the main document lowering phase an opportunity to add source location information which we then add after the main lowering.
- Re-generated csharp to capture addition of using statements that were previously overridden by defaults/imports.

#1174
NTaylorMullen added a commit that referenced this issue Apr 4, 2017
- The lazy addition of namespaces gives the main document lowering phase an opportunity to add source location information which we then add after the main lowering.
- Re-generated csharp to capture addition of using statements that were previously overridden by defaults/imports.

#1174
NTaylorMullen added a commit that referenced this issue Apr 4, 2017
- The lazy addition of namespaces gives the main document lowering phase an opportunity to add source location information which we then add after the main lowering.
- Re-generated csharp to capture addition of using statements that were previously overridden by defaults/imports.

#1174
@NTaylorMullen
Copy link
Member Author

72dfb1d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant