This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Updated the ir lowering phase to lazily add namespaces. #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Apr 4, 2017
| @@ -64,16 +54,31 @@ protected override void ExecuteCore(RazorCodeDocument codeDocument) | |||
|
|
|||
| visitor.VisitBlock(syntaxTree.Root); | |||
|
|
|||
| // In each lowering piece above, namespaces were tracked. We render them here to ensure every | |||
| // lowering action has a chance to add a source location to a namespace. | |||
There was a problem hiding this comment.
I would also mention here that the closest wins. We want to use the using from the main source file if possible.
rynowak
reviewed
Apr 4, 2017
|
|
||
| builder.Insert(i++, @using); | ||
| } | ||
|
|
||
| codeDocument.SetIRDocument(document); | ||
| } | ||
|
|
||
| private class LoweringVisitor : ParserVisitor |
ajaybhargavb
reviewed
Apr 4, 2017
| var @using = new UsingStatementIRNode() | ||
| { | ||
| Content = @namespace.Key, | ||
| Source = @namespace.Value, |
There was a problem hiding this comment.
When there are multiple identical usings, any chance one with null source appear later and overwrite one with source?
There was a problem hiding this comment.
Not in this phase 😄
NTaylorMullen
force-pushed
the
nimullen/usingimports.1174
branch
from
92695a2
to
4be7a20
Compare
- The lazy addition of namespaces gives the main document lowering phase an opportunity to add source location information which we then add after the main lowering. - Re-generated csharp to capture addition of using statements that were previously overridden by defaults/imports. #1174
NTaylorMullen
force-pushed
the
nimullen/usingimports.1174
branch
from
4be7a20
to
72dfb1d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1174