Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

@model with non-nullable model generates code with exception #1348

Closed
ryanbrandenburg opened this issue May 15, 2017 · 5 comments
Closed

@model with non-nullable model generates code with exception #1348

ryanbrandenburg opened this issue May 15, 2017 · 5 comments
Assignees
@NTaylorMullen
Labels
duplicate

Comments

@ryanbrandenburg
Copy link
Contributor

https://github.com/aspnet/Razor/blob/dev/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test/TestFiles/IntegrationTests/CodeGenerationIntegrationTest/ModelExpressionTagHelper.cshtml#L1 generates an exception because the generated code tries to assign null to the model. The test for this is skipped for now.
@ryanbrandenburg ryanbrandenburg mentioned this issue May 15, 2017
Merged
@rynowak
Copy link
Member

rynowak commented May 15, 2017

@NTaylorMullen this is potentially a tooling candidate

@rynowak
Copy link
Member

rynowak commented May 16, 2017

@ryanbrandenburg @NTaylorMullen - does this fail to compile? or just a runtime exception?

@ryanbrandenburg
Copy link
Contributor Author

It's a compile failure.

@rynowak rynowak added this to the 2.0.0-preview2 milestone May 16, 2017
@rynowak
Copy link
Member

rynowak commented May 16, 2017

@NTaylorMullen lets fix this for preview2

@NTaylorMullen NTaylorMullen removed this from the 2.0.0-preview2 milestone May 16, 2017
@NTaylorMullen
Copy link
Member

Just found that this was a dup of #1176

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rynowak @NTaylorMullen @ryanbrandenburg