Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Razor Tokens. #4985

Closed
NTaylorMullen opened this issue Jan 23, 2016 · 1 comment
Closed

Cache Razor Tokens. #4985

NTaylorMullen opened this issue Jan 23, 2016 · 1 comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-razor-pages Perf
Milestone
Backlog

Comments

@NTaylorMullen
Copy link
Contributor

Today Razor has ISymbols aka Tokens (should be renamed) and they are responsible for a large portion of allocations when compiling Razor pages (nearly 10%). We should cache these tokens to reduce their allocation numbers.

I took a stab at doing this and ran into some risky issues which is the reason why I'm writing this issue now. See here for details on what the implications of doing this are.

image
@Eilon
Copy link
Member

Eilon commented Jan 27, 2016

Moving to backlog.

@aspnet-hello aspnet-hello transferred this issue from aspnet/Razor Dec 14, 2018
@aspnet-hello aspnet-hello added this to the Backlog milestone Dec 14, 2018
@aspnet-hello aspnet-hello added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-razor-pages Perf labels Dec 14, 2018
@pranavkm pranavkm added the c label Aug 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-razor-pages Perf
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@pranavkm @Eilon @NTaylorMullen @mkArtakMSFT @aspnet-hello