Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Broken going to rc1-final but can't find matching breaking change annoucement #587

Closed
guardrex opened this issue Nov 26, 2015 · 4 comments
Closed

Comments

@guardrex
Copy link

I broke going to rc1-final. This used to work ...

capture

... but I seem to have lost the Notifications extension method, and I can't find OpenIdConnectAuthenticationNotifications, which might just be due to a wrong package ref (but there is no potential fix package recommendation by VS).

@davidfowl
Copy link
Member

/cc @Eilon @HaoK @Tratcher

AFAIK it was renamed to Events

@guardrex
Copy link
Author

I'll give that a shot.

@guardrex
Copy link
Author

Yes ... Events ... I guess it was supposed to be obvious so it didn't make the announcements. Next, I just need to get IOpenIdConnectConnectEvents in there, and I should be ok.

@guardrex
Copy link
Author

Looks like this is the new way ...

options.Events = new OpenIdConnectEvents
    {
        OnAuthenticationFailed = (context) => 
        {
            context.HandleResponse();
            context.Response.Redirect("/error/401");
            return Task.FromResult(0);
        },
        OnRedirectToAuthenticationEndpoint = (context) =>
        {
            return Task.FromResult(0);
        }
    };
});

Also,

OpenIdConnectAuthenticationDefaults.AuthenticationScheme

... has become ...

OpenIdConnectDefaults.AuthenticationScheme

Maybe an announcement for these changes? That's rather different from before, and searching for Notifications, OpenIdConnectAuthenticationNotifications, or OpenIdConnectAuthenticationDefaults didn't help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants