Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Consistent, configurable logging in the JavaScript client #485

Closed
analogrelay opened this issue May 24, 2017 · 5 comments
Closed

Consistent, configurable logging in the JavaScript client #485

analogrelay opened this issue May 24, 2017 · 5 comments
Assignees
Milestone

Comments

@analogrelay
Copy link
Contributor

The JavaScript client (and indeed all the clients) needs to have configurable logging rather than just relying on console.log as it does right now.

@moozzyk
Copy link
Contributor

moozzyk commented May 24, 2017

This was originally being tracked here: #3 but a separate issue makes it more visible.

@moozzyk moozzyk mentioned this issue May 24, 2017
21 tasks
@moozzyk
Copy link
Contributor

moozzyk commented May 24, 2017

#484 (comment)

@muratg
Copy link

muratg commented Aug 18, 2017

For alpha1: add ability to turn off console.log lines (for node.js usage).

In the next milestone we'll design/implement the right abstraction for client side logging.

@muratg
Copy link

muratg commented Aug 25, 2017

@moozzyk will also look into adding an options object at the HubConnection class. We want to have a bool value for logging, a logger object and hub protocol.

@moozzyk
Copy link
Contributor

moozzyk commented Aug 31, 2017

Fixed in: e4c1b88 and 7db480b

@moozzyk moozzyk closed this as completed Aug 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants