Skip to content
This repository has been archived by the owner on Nov 7, 2018. It is now read-only.

Revisit by-convention options from configuration #23

Closed
divega opened this issue Oct 17, 2014 · 4 comments
Closed

Revisit by-convention options from configuration #23

divega opened this issue Oct 17, 2014 · 4 comments
Assignees
Milestone

Comments

@divega
Copy link

divega commented Oct 17, 2014

@Eilon has expressed some concerns with the "amount of magic" in the current design that pulls configuration information into an instance of an options type MyOptions through a call to services.Configure<MyOptions>(configuration), and on how this is currently used across the frameworks. Filing this issue to track that so that we can have a follow up conversation.

@rustd rustd modified the milestone: 1.0.0-beta2 Oct 17, 2014
@HaoK
Copy link
Member

HaoK commented Oct 17, 2014

Related to this, currently all of the frameworks are implicitly expecting their options to live at top level, we need to change the behavior of all the frameworks AddFooXXX(Configuration) method to implicitly be looking for Configuration.GetSubKey("FooXXX") or pick some other naming convention to properly scope the options.

@divega divega modified the milestones: 1.0.0-beta2, 1.0.0-beta3 Jan 12, 2015
@HaoK
Copy link
Member

HaoK commented Jan 16, 2015

This is currently broken again, along with service replacement due to frameworks calling Add on their dependencies, i.e. Options, DataProtection, etc.

@rustd rustd modified the milestones: 1.0.0-beta3, 1.0.0-rc1 Jan 26, 2015
@HaoK
Copy link
Member

HaoK commented Mar 9, 2015

@davidfowl suggested that we just cut all automatic Configure options from any AddXyz methods, users can always manually call services.ConfigureXyz(config) to bind options to config. I will make a pass once builds are stable and remove Configuration from all AddXyz methods that do not need them

@HaoK
Copy link
Member

HaoK commented Mar 14, 2015

Removed Configuration/Automatic ConfigureOptions using config from AddXyz methods

@HaoK HaoK closed this as completed Mar 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants