-
Notifications
You must be signed in to change notification settings - Fork 40
Create "xunit" logger provider #243
Comments
We can certainly do this, but what would actually wire it up in our tests? And... what problem in our tests does it solve? |
|
Ah, got it, this makes sense. Are there any tests where we know we'd want to use this ASAP? I want to make sure that whoever I assign this to will have an actual use case for it 😄 |
Well there are places we already have it, https://github.com/aspnet/SignalR/blob/dev/test/Microsoft.AspNetCore.SignalR.Tests/XUnitLoggerProvider.cs , https://github.com/aspnet/MusicStore/blob/dev/test/E2ETests/Common/XunitLogger.cs , etc. So this more about making it a common component, to avoid copy 🍝 |
Closing in lieu of aspnet/Logging#574 |
In xunit, it is recommended that "console" output be written to
ITestOutputHelper
rather than the Console. We should provide a Logger to plug in toILoggerFactory
which writes to this. See https://github.com/aspnet/MusicStore/blob/dev/test/E2ETests/Common/XunitLogger.cs for an example./cc @natemcmaster
The text was updated successfully, but these errors were encountered: