Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional standard classifications (20-22) #11

Closed
esilvia opened this issue Mar 21, 2017 · 20 comments
Closed

Additional standard classifications (20-22) #11

esilvia opened this issue Mar 21, 2017 · 20 comments
Assignees
Milestone

Comments

@esilvia
Copy link
Member

esilvia commented Mar 21, 2017

From Lewis:

19 – Conveyor or other overhead machinery (see #26)
20 – Ignored Ground (typ. breakline proximity)
21 – Snow
22 – Temporal Exclusion (often where a tidal-coordinated or topobathy swath supercedes other data)

19 is a de facto class that has been in use for mine site mapping.
20-22 are requests from USGS

@esilvia
Copy link
Member Author

esilvia commented Mar 21, 2017

From Karl:

Based on prior communications I have had with Lewis, I have included 20-22 in the USGS LBS v13, which is still in Draft review.

If there is any uncertainty about the use of these class codes as Lewis has noted, I need to know immediately, as we do not want the LBS to contradict the LAS specification.

@esilvia
Copy link
Member Author

esilvia commented Apr 10, 2017

Up for discussion: Is this the sort of change we are willing to incorporate as a revision, or should classes only be dedicated in major/minor version updates (i.e., 1.5/2.0)?

@rapidlasso
Copy link
Member

I think a revision will do as long as the newly defined classes do not override any previous definition.

@esilvia esilvia added this to the v1.4 R14 milestone May 9, 2017
@gadomski
Copy link

gadomski commented Feb 5, 2018

If snow is being added, it might make sense to add ice as well? Many users who care about snow classifications also care about ice and discriminating between the two. This suggestion comes from @jsdeems of NSIDC, who deals with and use a lot of snow+ice point clouds and works with many other people who do as well.

@esilvia
Copy link
Member Author

esilvia commented Feb 22, 2018

@gadomski Intriguing request. Is there a class that multiple parties have been using for Ice?

@gadomski
Copy link

Not that I know of, but @jsdeems knows more than I do. I'll check with him when he gets back from his ski trip (I don't know if he checks Github) and let you know if he has a suggestion.

@esilvia
Copy link
Member Author

esilvia commented Oct 18, 2018

Class 19 has been reserved for Overhead Structure in R14 (#26). I'm considering that discussion closed and off-topic in this thread.

I haven't seen further discussion for classes 20-22 except to note that they have been added to the USGS LBS 1.3 as follows:

  • 20 – Ignored Ground (typically breakline proximity)
  • 21 – Snow (if present and identifiable)
  • 22 – Temporal Exclusion (typically nonfavored data in intertidal zones)

Is there any reason not to integrate these into the LAS 1.4 specification to keep the two in sync? @jdnimetz @jstoker74 @gadomski

@esilvia esilvia self-assigned this Oct 18, 2018
@jdnimetz
Copy link
Member

I see no reason not to integrate these classes into LAS 1.4 spec., but I’m biased 🙂
FWIW, there are no plans to change definition for these three classes within the 3DEP LBS.

@milenajaniec
Copy link

Indeed, it would help to include classes 20-22 😊

@esilvia
Copy link
Member Author

esilvia commented Oct 30, 2018

@milenajaniec
Copy link

Thank you Evon :) Would you please also add
22 – Temporal Exclusion

Also, are there any immediate objections to adding the following classes:
40 Bathymetric bottom / Bathymetric point /Submerged topography / Seafloor or riverbed
41 Water surface
42 Derived water surface /synthetic
43 Submerged object (unspecified)
44 International Hydrographic Organization object (unspecified)
45 Water column /No bottom found at bathy point/ Neither surface nor bottom

From my (subjective) perspective it would be helpful to have these classes formally standardized. Please let me know :)

@kjwaters
Copy link

kjwaters commented Nov 2, 2018 via email

@parrishOSU
Copy link

I definitely concur with adding/formalizing topo-bathy domain profile classes 40-45, as defined in Milena's post, and 46, as defined by Kirk. I'm not quite sure what 22 (temporal exclusion) is. Would this refer to a point excluded, due to being inside or outside a defined time window?

@milenajaniec
Copy link

a) Kirk, I see your point, I think class 46 (submerged aquatic vegetation) would be a useful addition.

b) Does anyone have any preferences in terms of naming classes 40-45?

c) Within the USGS specification class 22 is currently defined as "typically nonfavored data in intertidal zones (https://pubs.usgs.gov/tm/11b4/pdf/tm11-B4.pdf p. 24)". However, it seems that, in some cases, folks also used it to signify temporal difference within a floodplain, or to call attention to an area where, during the data collection, a significant event resulted in an elevation difference (with the most recent data within the identified area being used). Josh, please comment if this interpretation is incorrect.

@esilvia
Copy link
Member Author

esilvia commented Nov 6, 2018

@milenajaniec That's how we've used Temporal Exclusion (22) in the past. For example, a water surface might get moved to this class if a later survey recorded it at a different height. Or the old ground surface might get classed 22 if it experienced a landslide between two acquisition dates.

Basically, the idea is that it captures terrain features that did exist but we have reason to believe no longer exists in their prior position, and removing them significantly improves the ground model.

Regarding incorporating the topobathy LDP classes, I'm reluctant to formalize classifications that only serve a single domain. I know there's already some reserved classifications for the utility sector, but I think that was a mistake and it's too late for me to change it. I'd rather promote usage of LDPs.

I acknowledge that the topobathy LDP is badly in need of updating. Personally, I think that's a separate issue. I haven't figured out yet what the best publication method for that will be (wiki, standalone PDF, LAS spec).

@milenajaniec
Copy link

milenajaniec commented Nov 6, 2018

@esilvia I understand your reluctance; however, since we are receiving an increased number of the topo-bathymetric projects, it would be worth to accommodate them somehow in the revision. Currently, the classification seems to be open. It would be helpful if we could standardize it. Especially, since we are already making changes. We could endeavor to formally incorporate the above-mentioned classes (which are already in use) at the same time.

@esilvia esilvia changed the title Additional standard classifications Additional standard classifications (19-22) Nov 12, 2018
@esilvia
Copy link
Member Author

esilvia commented Nov 13, 2018

It sounds like we're all in favor of the addition of Temporal Exclusion (class 22), so I'll integrate that as a pull request. One question I wasn't sure about... is Temporal Exclusion only for ground points that are being excluded, or is it for any features? I believe that ground is the norm, but I'm not sure.

It didn't make sense to me to include the parentheticals from the LBS in the class names, so I added a Notes column for PDRF 6 like this:
image

If there are no objections, I'll close this issue.

Finally, I've migrated the topobathy LDP class discussion over to #72 and limited this issue to 19-22 since we seem to be agreed on those. Perhaps the topobathy classes can be part of R15. Hope that doesn't cause too much confusion.

esilvia added a commit that referenced this issue Nov 13, 2018
@esilvia esilvia changed the title Additional standard classifications (19-22) Additional standard classifications (20-22) Nov 13, 2018
@esilvia
Copy link
Member Author

esilvia commented Nov 13, 2018

Closed with #73

@kjwaters
Copy link

kjwaters commented May 2, 2019 via email

@esilvia
Copy link
Member Author

esilvia commented May 20, 2019

Removing non-permanent objects is one possibility, but it was intended more for terrain features that changed over time. Consider the following:

  1. Flightlines 1012-1014 collected in January on a hillside.
  2. Landslide in February.
  3. Adjacent flightlines 1015-1020 collected in March.

So now the terrain within the project area has changed. What do you do with the ground from 1012-1014 that no longer exists as a result of the landslide in February? You don't want to switch it to class 1 because that'd make it look like vegetation, but you don't want it to be class 2 because it no longer exists.

The idea is that you'd select the set of terrain you're interested in and use the standard classes, then classify the other terrain to 22 as Temporal Exclusion. Most of the time the January (older) flight would end up as Class 22 and the newer flight would be kept in the standard classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants