Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

Vanity fails to set identify_block on high load #2

Closed
dziulius opened this issue Feb 9, 2010 · 1 comment
Closed

Vanity fails to set identify_block on high load #2

dziulius opened this issue Feb 9, 2010 · 1 comment

Comments

@dziulius
Copy link

dziulius commented Feb 9, 2010

When load is very high, we randomly get
undefined method `call' for nil:NilClass
error

/usr/local/lib/ruby/gems/1.8/gems/vanity-1.2.0/lib/vanity/experiment/base.rb:108:in `identity'

/usr/local/lib/ruby/gems/1.8/gems/vanity-1.2.0/lib/vanity/experiment/ab_test.rb:190:in `choose'

/usr/local/lib/ruby/gems/1.8/gems/vanity-1.2.0/lib/vanity/rails/helpers.rb:91:in `ab_test'

@assaf
Copy link
Owner

assaf commented Feb 16, 2010

Thanks. This seem unrelated to load, simply a bug in the choose method of AbTest that calls identify instead of identity. Fixing now.

khdegraaf referenced this issue in khdegraaf/vanity Aug 31, 2012
…e/add-default-alternative

Feature/add default alternative
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants