Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 7.0.0 is not compatible with the latest release of openapi-ts@4.3.2 #235

Closed
callmeberzerker opened this issue May 28, 2024 · 7 comments

Comments

@callmeberzerker
Copy link

See this PR metadevpro/openapi3-ts#117

# pnpm why openapi-ts
devDependencies:
@asteasolutions/zod-to-openapi 7.0.0
└── openapi3-ts 4.3.2

Error reported:

Found 6 errors in 4 files.

Errors  Files
     2  node_modules/.pnpm/@asteasolutions+zod-to-openapi@7.0.0_zod@3.23.8/node_modules/@asteasolutions/zod-to-openapi/dist/openapi-registry.d.ts:1
     1  node_modules/.pnpm/@asteasolutions+zod-to-openapi@7.0.0_zod@3.23.8/node_modules/@asteasolutions/zod-to-openapi/dist/v3.0/openapi-generator.d.ts:1
     1  node_modules/.pnpm/@asteasolutions+zod-to-openapi@7.0.0_zod@3.23.8/node_modules/@asteasolutions/zod-to-openapi/dist/v3.1/openapi-generator.d.ts:1
     2  node_modules/.pnpm/@asteasolutions+zod-to-openapi@7.0.0_zod@3.23.8/node_modules/@asteasolutions/zod-to-openapi/dist/zod-extensions.d.ts:1

Reproduction steps:

  1. Create a new TS project with module setting in tsconfig.json to CommonJS.
  2. Run pnpm install
  3. Run pnpm tsc
@reju1021
Copy link

Just ran into the same problem. I also tried out different older versions which are all also affected by this.

@AGalabov
Copy link
Collaborator

@callmeberzerker thank you for reporting that. We will look at this as soon as we can.

@reju1021 do you mean that this is also a problem on older openapi3-ts versions or older versions of @asteassolutions/zod-to-openapi

@reju1021
Copy link

reju1021 commented Jun 3, 2024

@AGalabov seems to be the case for older versions of @asteassolutions/zod-to-openapi too. Thanks for looking into this!

@andreujuanc
Copy link

Pinning the version works for me: "openapi3-ts": "4.3.1"

andreujuanc referenced this issue in metadevpro/openapi3-ts Jun 10, 2024
@andreujuanc
Copy link

Update: this fixed the problem: metadevpro/openapi3-ts#138 give some thumbs up xD

@reju1021
Copy link

Appreciate the fix @andreujuanc - this resolved the issue for me as well! :)

@AGalabov
Copy link
Collaborator

@andreujuanc thank you for the fix. I will close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants