Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support subpath for tsc with moduleResolutin node #117

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

koooge
Copy link
Contributor

@koooge koooge commented Apr 20, 2023

resolves #114

@pjmolina
Copy link
Contributor

Is the PR ready @koooge or should await for any missing issue before merging? Thanks for the good work, BTW.

@koooge
Copy link
Contributor Author

koooge commented Apr 24, 2023

@pjmolina Still WIP. I will update this and ping you.

Signed-off-by: koooge <koooooge@gmail.com>
Signed-off-by: koooge <koooooge@gmail.com>
@koooge koooge marked this pull request as ready for review April 24, 2023 23:04
@koooge
Copy link
Contributor Author

koooge commented Apr 24, 2023

@pjmolina Now it's ready to review!

Copy link
Contributor

@pjmolina pjmolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@pjmolina pjmolina merged commit 36c958a into metadevpro:master Apr 25, 2023
@RobinTail
Copy link
Contributor

Thank you for fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import oas31 using ESM in openapi3-ts@4.1.1
3 participants