-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Pedro J. Molina
committed
May 23, 2024
1 parent
1165ddd
commit 7eab2d1
Showing
3 changed files
with
233 additions
and
275 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
7eab2d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pjmolina
This change broke asteasolutions/zod-to-openapi#235
IMHO, it should not have been a patch but a minor change on semver.
7eab2d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the incoveniences caused. You are rigth.
To undestand it in full: Did zod was using/depending on the sources distributed instead of the
dist
folder?7eab2d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, let's try to figure out what's happening!
It was not zod, but this library, which takes a zod schema and converts it to an openapi spec: https://github.com/asteasolutions/zod-to-openapi
And no, I don't think they were using the sources, I"m checking the repo and they do this
import type { OpenAPIObject } from 'openapi3-ts/oas30';
Fixed the problem by manually re-adding oas30.d.ts and oas31.d.ts back to the root
![image](https://private-user-images.githubusercontent.com/360052/338203124-7be5bfa0-f43a-4e62-9f6f-6ee1db9d59b3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3NzYxNTcsIm5iZiI6MTcyNTc3NTg1NywicGF0aCI6Ii8zNjAwNTIvMzM4MjAzMTI0LTdiZTViZmEwLWY0M2EtNGU2Mi05ZjZmLTZlZTFkYjlkNTliMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwOFQwNjEwNTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lYWYxNWE4YjIzZWEwMDllMTMzZWEyNDkzYWQwZTZkYjJhZmEwZjI3YjM0ZjI0MDYyYzkxYTQ3NDI4NDQxNjAyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.h0fzxb9wNKSvkEmYPCUo4SU64mBi07CGWvWLOfFtrws)
@pjmolina Would love to get this out if possible #138
7eab2d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, please remove the extra comma on package JSON and will merge and publish asap.