Skip to content

Commit

Permalink
publish 4.3.2
Browse files Browse the repository at this point in the history
  • Loading branch information
Pedro J. Molina committed May 23, 2024
1 parent 1165ddd commit 7eab2d1
Show file tree
Hide file tree
Showing 3 changed files with 233 additions and 275 deletions.
6 changes: 6 additions & 0 deletions Changelog.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog: openapi3-ts

## Version 4.3.2

2024.05.23

- Fix [#134](https://github.com/metadevpro/openapi3-ts/pull/134) exceisve files in distributed package. PR [136](https://github.com/metadevpro/openapi3-ts/pull/136) by @RobinTail

## Version 4.3.1

2024.04.01
Expand Down
Loading

4 comments on commit 7eab2d1

@andreujuanc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pjmolina
This change broke asteasolutions/zod-to-openapi#235
IMHO, it should not have been a patch but a minor change on semver.

@pjmolina
Copy link
Contributor

@pjmolina pjmolina commented on 7eab2d1 Jun 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the incoveniences caused. You are rigth.
To undestand it in full: Did zod was using/depending on the sources distributed instead of the dist folder?

@andreujuanc
Copy link
Contributor

@andreujuanc andreujuanc commented on 7eab2d1 Jun 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, let's try to figure out what's happening!
It was not zod, but this library, which takes a zod schema and converts it to an openapi spec: https://github.com/asteasolutions/zod-to-openapi
And no, I don't think they were using the sources, I"m checking the repo and they do this import type { OpenAPIObject } from 'openapi3-ts/oas30';

Fixed the problem by manually re-adding oas30.d.ts and oas31.d.ts back to the root
image

@pjmolina Would love to get this out if possible #138

@pjmolina
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, please remove the extra comma on package JSON and will merge and publish asap.

Please sign in to comment.