Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move error rejection function to beginning? #68

Closed
Gabriel-p opened this issue Jul 18, 2014 · 1 comment
Closed

Move error rejection function to beginning? #68

Gabriel-p opened this issue Jul 18, 2014 · 1 comment
Assignees
@Gabriel-p
Labels
priority:low question type:errors type:structure
Milestone
v0.2.6

Comments

@Gabriel-p
Copy link
Contributor

Gabriel-p commented Jul 18, 2014 •
edited
Loading

Should the error rejection function be moved to the beginning of the code so it will also affect the structural parameters (ie: center, radius) in addition to the rest?

Currently the rejection is applied after the center and radius are assigned. This is problematic in particular for those frames that contain artifacts not removed during the reduction/photometry process.

Related to #107, #14
@Gabriel-p Gabriel-p added this to the v1.1 milestone Jul 18, 2014
@Gabriel-p Gabriel-p self-assigned this Jul 18, 2014
@Gabriel-p Gabriel-p mentioned this issue Oct 23, 2014
Closed
@Gabriel-p Gabriel-p mentioned this issue Nov 10, 2014
Closed
@Gabriel-p Gabriel-p removed the ready label Dec 3, 2014
@Gabriel-p Gabriel-p modified the milestones: v0.2.1, v1.0.0 Feb 24, 2015
@Gabriel-p Gabriel-p modified the milestones: v0.7.0, v0.8.0 Sep 7, 2015
@Gabriel-p Gabriel-p removed the Backlog label May 6, 2018
@Gabriel-p
Copy link
Contributor Author

After a lot of thought: no, it should not.

If there are artifacts in the image, they should be either removed manually, or handled with #14

@Gabriel-p Gabriel-p modified the milestones: v0.7.0, v0.2.6 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gabriel-p Gabriel-p

Labels
priority:low question type:errors type:structure
Projects
None yet
Milestone
v0.2.6
Development

No branches or pull requests
1 participant
@Gabriel-p