Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: res_pjsip_logger: Reload disables logging #246

Closed
1 task done
InterLinked1 opened this issue Aug 9, 2023 · 0 comments · Fixed by #247
Closed
1 task done

[bug]: res_pjsip_logger: Reload disables logging #246

InterLinked1 opened this issue Aug 9, 2023 · 0 comments · Fixed by #247
Assignees
@InterLinked1
Labels
bug support-level-core Functionality with core support level

Comments

@InterLinked1
Copy link
Contributor

Severity

Minor

Versions

All

Components/Modules

res_pjsip_logger

Operating Environment

N/A

Frequency of Occurrence

Constant

Issue Description

Imported from JIRA: https://issues.asterisk.org/jira/browse/ASTERISK-29912

When res_pjsip is reloaded, any logging enabled in res_pjsip_logger via the CLI is disabled. This is a behavior difference from basically every other module, including chan_sip, and has caused confusion and annoyance for many users.

Relevant log output

No response

Asterisk Issue Guidelines

  • Yes, I have read the Asterisk Issue Guidelines
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Aug 9, 2023
@InterLinked1
res_pjsip_logger: Preserve logging state on reloads.
d1846c2 
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: asterisk#246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
@InterLinked1 InterLinked1 mentioned this issue Aug 9, 2023
Merged
@jcolp jcolp added support-level-core Functionality with core support level and removed triage labels Aug 9, 2023
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Mar 21, 2024
@InterLinked1
res_pjsip_logger: Preserve logging state on reloads.
acf5122 
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: asterisk#246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Apr 1, 2024
@InterLinked1
res_pjsip_logger: Preserve logging state on reloads.
9e6df16 
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: asterisk#246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Apr 4, 2024
@InterLinked1
res_pjsip_logger: Preserve logging state on reloads.
7555b27 
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: asterisk#246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
asterisk-org-access-app bot pushed a commit that referenced this issue May 1, 2024
@InterLinked1
res_pjsip_logger: Preserve logging state on reloads.
3b600e2 
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: #246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
asterisk-org-access-app bot pushed a commit that referenced this issue May 1, 2024
@InterLinked1
res_pjsip_logger: Preserve logging state on reloads.
001176c 
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: #246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
asterisk-org-access-app bot pushed a commit that referenced this issue May 1, 2024
@InterLinked1
res_pjsip_logger: Preserve logging state on reloads.
9fc596a 
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: #246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
asterisk-org-access-app bot pushed a commit that referenced this issue May 1, 2024
@InterLinked1 @asterisk-org-access-app
res_pjsip_logger: Preserve logging state on reloads.
077962d 
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: #246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@InterLinked1 InterLinked1

Labels
bug support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

res_pjsip_logger: Preserve logging state on reloads. InterLinked1/asterisk
2 participants
@jcolp @InterLinked1