Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource specific events inconsistent with Client events #4

Closed
samuelg opened this issue Aug 26, 2014 · 0 comments
Closed

Resource specific events inconsistent with Client events #4

samuelg opened this issue Aug 26, 2014 · 0 comments
Assignees
Labels

Comments

@samuelg
Copy link
Contributor

samuelg commented Aug 26, 2014

Client events use a built in EventEmitter. Resource specific events however use a wrapper around an EventEmitter. Some of the implementation is inconsistent with the way an EventEmitter should work.

1 - attaching more than one callback via resource.on('event', callback) only attaches the first callback
2 - removeListener acts like removeAllListeners but does not actually remove the underlying EventEmitter attached callback
3 - removeAllListeners is not implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant