Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytorch-optimizer dropped RAdam optimizer #567

Closed
ben-freist opened this issue Oct 28, 2021 · 3 comments
Closed

Pytorch-optimizer dropped RAdam optimizer #567

ben-freist opened this issue Oct 28, 2021 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ben-freist
Copy link
Contributor

🐛 Bug

In jettify/pytorch-optimizer#377 pytorch-optimizer was updated and no longer includes the RAdam optimizer but asteroid/engine/optimizers.py still tries to import it.

At the moment I've added pytorch-optimizers < 0.2.0 to my requirements.txt to work around it.

Package versions

My asteroid version is 0.5.0dev, but it looks like the situation is the same on master.
@ben-freist ben-freist added bug Something isn't working help wanted Extra attention is needed labels Oct 28, 2021
@mpariente
Copy link
Collaborator

Thanks for the issue.
Could you make a PR adding this change to the requirement file please? That would be great, thanks !

@mpariente mpariente mentioned this issue Oct 28, 2021
Closed
@ben-freist
Copy link
Contributor Author

No problem, I just created the MR.

@mpariente
Copy link
Collaborator

Closed by #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpariente @ben-freist