Drop radam optimizer. #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 83.50% 82.70% -0.81%
==========================================
Files 27 26 -1
Lines 1716 1642 -74
Branches 391 371 -20
==========================================
- Hits 1433 1358 -75
- Misses 165 167 +2
+ Partials 118 117 -1
Continue to review full report at Codecov.
|
ben-freist
added a commit
to ben-freist/asteroid
that referenced
this pull request
Oct 28, 2021
In jettify/pytorch-optimizer#377 the RAdam optimizer was removed from pytorch-optimizer, it's still used in aseroid though.
mpariente
pushed a commit
to asteroid-team/asteroid
that referenced
this pull request
Oct 28, 2021
In jettify/pytorch-optimizer#377 the RAdam optimizer was removed from pytorch-optimizer, it's still used in asteroid though.
|
It would have been nice to deprecate this more gracefully -- the change just broke most of the VQGAN+CLIP tutorials that are out in the wild. |
|
Sorry about that, will restore with proper deprecation. |
jettify
added a commit
that referenced
this pull request
Oct 31, 2021
|
@clayheaton sorry for inconvenience I reverted change and release new version. |
|
Thank you very much!
… On Oct 30, 2021, at 11:02 PM, Nikolay Novik ***@***.***> wrote:
@clayheaton sorry for inconvenience I reverted change and release new version.
https://pypi.org/project/torch-optimizer/0.3.0/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop radam since it is included in pytorch.