-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop radam optimizer. #377
Conversation
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 83.50% 82.70% -0.81%
==========================================
Files 27 26 -1
Lines 1716 1642 -74
Branches 391 371 -20
==========================================
- Hits 1433 1358 -75
- Misses 165 167 +2
+ Partials 118 117 -1
Continue to review full report at Codecov.
|
In jettify/pytorch-optimizer#377 the RAdam optimizer was removed from pytorch-optimizer, it's still used in aseroid though.
In jettify/pytorch-optimizer#377 the RAdam optimizer was removed from pytorch-optimizer, it's still used in asteroid though.
It would have been nice to deprecate this more gracefully -- the change just broke most of the VQGAN+CLIP tutorials that are out in the wild. |
Sorry about that, will restore with proper deprecation. |
@clayheaton sorry for inconvenience I reverted change and release new version. |
Thank you very much!
… On Oct 30, 2021, at 11:02 PM, Nikolay Novik ***@***.***> wrote:
@clayheaton sorry for inconvenience I reverted change and release new version.
https://pypi.org/project/torch-optimizer/0.3.0/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Drop radam since it is included in pytorch.